We ensure we’re shipping high quality backend code, we put teammates first by using code reviews as a way to help them do their best work, and we keep stories moving through our process.
Expectations / Description
- We ensure we’re shipping high quality backend codeand give actionable feedback on code including (but not limited to) the following areas:
- ~90% test coverage on stories
- Performance
- Security
- Style guide
- Architectural patterns
- Hygienic (common conventions) concerns
- We put teammates first by using code reviews as a way to help them do their best work
- We offer advice and resources to share knowledge and teach others
- We discuss the advantages and disadvantages of different approaches
- We keep stories moving through our process
- We review at least one story for every story we own
Handbook(s)
- Code Reviews: Part of our Engineer onboarding, this Lesson details the process and mechanics of a Code Review.
- Story Workflow: Code Reviews: Also part of our Engineer onboarding, this Lesson outlines the expectations of code reviewers and who is responsible at each review-related stage in our workflow.
- Code Reviews: What to Look For: A compendium of everything we've learned (and thought to write down) about reviewing code in the context of our application and domain. A great getting-started guide for new reviewers on the team.
Requirements
- Back End Code Reviewer's must have a position with the reach of 1.1 or higher
- Back End Code Reviewer's must be milestone 1+,Ruby
- Back End Code Reviewer's must be milestone 1+,Rails
- Back End Code Reviewer's must be milestone 1+,Data
- Back End Code Reviewer's must be milestone 1+,Prioritization
- Back End Code Reviewer's must be milestone 1+,Collaboration
- Back End Code Reviewer's must be milestone 1+,Engineering Communication
Configuration Health
- ✅ Has 6 Abilities
- ✅ Is a part of 36 Positions
- ✅ Has been referenced in 3 pieces of public recognition
- ℹ️ Fewer than five people (1) have reacted to this Assignment. To ensure anonymity, analysis will only appear after at least five people have reacted.
- ℹ️ 5 people have an official rating on this Assignment: 0 people are exceeding expectations, 0 people are working towards meeting expectations, and 2 people are meeting expectations
- ⛔️ Last updated: over 4 years ago
- ℹ️ Never conversed about
Examples / Observations
Observation created almost 5 years agoI'm thankful for Brittany's PR updating our seeds file.
First, she noticed that the test data it produces has gotten out of date over time and didn't provide an optimal testing environment. This PR is a step towards addressing that need. She also introduced a cool concept of using the filler text in Lessons as a way to help provide guidance on how they are expected to work. What a cool idea that provides assistance at the time of need while also providing realistic test data!
Secondly, her PR notes very clearly shared the context behind these proposed changes, explained her solution, and even included "hot tips" to help call out pitfalls while testing it. I appreciate this because I was very quickly able to not only understand her changes, but think about them in the context of the problem they were aiming to solve. All of this information was conveyed in format that was concise and easy for me to follow, which is not easy in itself. While I found the PR description helpful, it will also provide helpful context to the next person to work in the seeds file :tada:
Observation created about 5 years agoTom and I both consulted on the design of the new content search. While doing a PR for some of this work, he looked beyond the syntax. He noticed that the flow of the code was likely going to not be performant for large clients. This is a critical skill to be able to look at code, understand the broader flow and intuit that there could be a problem for larger data sets. Finding this issue put Tom in a crossroads. Pulling the Andon cord on this is a non-trivial act. He reached out to me to make sure that we were in agreement about the issue and to make sure that solutions to this problem were larger in scope than PR comments could address. He then took responsibility to drive clarity with the rest of the team and make sure they were all prepared to come up with a new plan.
Official Back End Code Reviewers
This section is for Lessonly folks only. Sign your team up to find your Gruuv!
Teams needing a Back-end Code Reviewer
This section is for Lessonly folks only. Sign your team up to find your Gruuv!
Positions that reference being a Back-end Code Reviewer
This section is for Lessonly folks only. Sign your team up to find your Gruuv!
Conversations about Back-end Code reviewer
This section is for Lessonly folks only. Sign your team up to find your Gruuv!