We put teammates first by using code reviews as a way to help them continuously improve while continuously delivering value
Expectations / Description
Code reviewers help in our quest to push quality to the left by giving actionable feedback on code including (but not limited to) the following areas:
- Test Coverage
- Performance
- Security
- Coding Conventions
- Architectural patterns
We put teammates first by using code reviews as a way to help them do their best work
- We offer advice and resources to share knowledge and teach others
- We discuss the advantages and disadvantages of different approaches
- We aim to balance the number of PRs we create with the number of PRs we review
Notes:
As an engineer grows their engineering skills, they will be able to tackle larger and more complex code reviewers. A good guideline for what an engineer would be able to review successfully is to compare the complexity of a PR to their current ruby/rails milestones. Participating in code reviews for code at higher ruby/rails milestones is a great way to get more experience and grow, but having a more senior engineer to approve/act as a second set of eyes can be a good guardrail for safety.
Requirements
- Code Reviewer's must have a position with the reach of 2.1 or higher
- Code Reviewer's must be milestone 2+,Collaboration
- Code Reviewer's must be milestone 2+,Engineering Communication
- Code Reviewer's must be milestone 1+,Data Modeling / Management
- Code Reviewer's are recommended to be milestone 1+,Engineering Prioritization
- Code Reviewer's must be milestone 2+,Ruby
- Code Reviewer's are recommended to be milestone 2+,Rails
Configuration Health
- ✅ Has 6 Abilities
- ✅ Is a part of 8 Positions
- ⚠️ Has been referenced in no observations
- ℹ️ No one has reacted to this Assignment
- ℹ️ Fewer than five people (1) have an official rating on this Assignment. To ensure anonymity, analysis will only appear after at least five people have ratings.
- ⛔️ Last updated: about 2 years ago
- ℹ️ Never conversed about
Examples / Observations
An observation relating to Code Reviewer has not been publicly recognized yet.
Official Code Reviewers
This section is for CareerPlug folks only. Sign your team up to find your Gruuv!
Teams needing a Code Reviewer
This section is for CareerPlug folks only. Sign your team up to find your Gruuv!
Positions that reference being a Code Reviewer
This section is for CareerPlug folks only. Sign your team up to find your Gruuv!
Conversations about Code Reviewer
This section is for CareerPlug folks only. Sign your team up to find your Gruuv!