Lessonly

• Product & Engineering

   Assignments:

  --None--

  ---

  • Engineering

     Assignments:

    --None--

    ---

    • Development

       Assignments:

      Front-end Code Reviewer

      We ensure we’re shipping high quality frontend code, we put teammates first by using code reviews as a way to help them do their best work, and we keep stories moving through our process.

      Full Description

      • We ensure we’re shipping high quality frontend code and give actionable feedback on code including (but not limited to) the following areas:
        • Performance
        • Security
        • Style guide
        • Architectural patterns
        • Hygienic (common conventions) concerns
      • We put teammates first by using code reviews as a way to help them do their best work
        • We offer advice and resources to share knowledge and teach others
        • We discuss the advantages and disadvantages of different approaches
      • We keep stories moving through our process
        • We review at least one story for every story we own

      Requirements

      • Must have a position with the reach of 1.1 or higher
      • For this role, you must be milestone 1 or greater inPrioritization
      • For this role, you must be milestone 1 or greater inWeb Technologies
      • For this role, you must be milestone 1 or greater inReact
      • For this role, you must be milestone 1 or greater inCollaboration
      • For this role, you must be milestone 1 or greater inEngineering Communication

      Examples

      An observation relating to  Front-end Code Reviewer  has not been publicly recognized yet.

      Back-end Code reviewer

      We ensure we’re shipping high quality backend code, we put teammates first by using code reviews as a way to help them do their best work, and we keep stories moving through our process.

      Full Description

      • We ensure we’re shipping high quality backend codeand give actionable feedback on code including (but not limited to) the following areas:
        • ~90% test coverage on stories
        • Performance
        • Security
        • Style guide
        • Architectural patterns
        • Hygienic (common conventions) concerns
      • We put teammates first by using code reviews as a way to help them do their best work
        • We offer advice and resources to share knowledge and teach others
        • We discuss the advantages and disadvantages of different approaches
      • We keep stories moving through our process
        • We review at least one story for every story we own

      ---

      Handbook(s)

      • Code Reviews: Part of our Engineer onboarding, this Lesson details the process and mechanics of a Code Review.
      • Story Workflow: Code Reviews: Also part of our Engineer onboarding, this Lesson outlines the expectations of code reviewers and who is responsible at each review-related stage in our workflow.
      • Code Reviews: What to Look For: A compendium of everything we've learned (and thought to write down) about reviewing code in the context of our application and domain. A great getting-started guide for new reviewers on the team.

      Requirements

      • Must have a position with the reach of 1.1 or higher
      • For this role, you must be milestone 1 or greater inRuby
      • For this role, you must be milestone 1 or greater inRails
      • For this role, you must be milestone 1 or greater inData
      • For this role, you must be milestone 1 or greater inPrioritization
      • For this role, you must be milestone 1 or greater inCollaboration
      • For this role, you must be milestone 1 or greater inEngineering Communication

      Examples

        Observation created almost 5 years ago

      Featuring:Brittany H.Engineering CommunicationCommunicationBack-end Code reviewer

      I'm thankful for Brittany's PR updating our seeds file.

      First, she noticed that the test data it produces has gotten out of date over time and didn't provide an optimal testing environment. This PR is a step towards addressing that need. She also introduced a cool concept of using the filler text in Lessons as a way to help provide guidance on how they are expected to work. What a cool idea that provides assistance at the time of need while also providing realistic test data!

      Secondly, her PR notes very clearly shared the context behind these proposed changes, explained her solution, and even included "hot tips" to help call out pitfalls while testing it. I appreciate this because I was very quickly able to not only understand her changes, but think about them in the context of the problem they were aiming to solve. All of this information was conveyed in format that was concise and easy for me to follow, which is not easy in itself. While I found the PR description helpful, it will also provide helpful context to the next person to work in the seeds file :tada:

        Observation created about 5 years ago

      Featuring:Thomas C.Back-end Code reviewerBack-end engineer

      Tom and I both consulted on the design of the new content search. While doing a PR for some of this work, he looked beyond the syntax. He noticed that the flow of the code was likely going to not be performant for large clients. This is a critical skill to be able to look at code, understand the broader flow and intuit that there could be a problem for larger data sets. Finding this issue put Tom in a crossroads. Pulling the Andon cord on this is a non-trivial act. He reached out to me to make sure that we were in agreement about the issue and to make sure that solutions to this problem were larger in scope than PR comments could address. He then took responsibility to drive clarity with the rest of the team and make sure they were all prepared to come up with a new plan.

      Back-end engineer

      We ship high quality code, we’re highly confident in providing the best experience for our users, and we deliver backend stories to contribute to the team’s success and keep progress moving forward.

      Full Description

      • We ship high quality code
        • Minimal (less than average) number of regrettable recycles on stories owned. For example:
          • ~90% test coverage
            • So we can (Shared) increase confidence that our code will work as expected
            • Not-you, engineering experience
          • Performance concerns
          • Security concerns
          • Style guide concerns
          • Architectural pattern concerns
          • Hygienic (common conventions) concerns
      • We’re highly confident in providing the best experience for our users
        • Minimal (less than average) number of regrettable remediations on stories owned. For example:
          • Performance issues
          • Authorization issues
          • Functionality issues
          • Error handling issues
      • Delivers backend stories to contribute to the team’s success and keep progress moving forward
        • Better than average cycle time of active states (as defined in OurGruuv)

      Requirements

      • Must have a position with the reach of 1.1 or higher
      • For this role, you must be milestone 1 or greater inRuby
      • For this role, you must be milestone 1 or greater inRails
      • For this role, you must be milestone 1 or greater inData
      • For this role, you must be milestone 1 or greater inEstimation
      • For this role, you must be milestone 1 or greater inInitiative
      • For this role, you must be milestone 1 or greater inPrioritization
      • For this role, you must be milestone 1 or greater inCollaboration
      • For this role, you must be milestone 1 or greater inEngineering Communication
      • For this role, you must be milestone 1 or greater inSoftware Investigation

      Examples

        Observation created about 5 years ago

      Featuring:Thomas C.Back-end Code reviewerBack-end engineer

      Tom and I both consulted on the design of the new content search. While doing a PR for some of this work, he looked beyond the syntax. He noticed that the flow of the code was likely going to not be performant for large clients. This is a critical skill to be able to look at code, understand the broader flow and intuit that there could be a problem for larger data sets. Finding this issue put Tom in a crossroads. Pulling the Andon cord on this is a non-trivial act. He reached out to me to make sure that we were in agreement about the issue and to make sure that solutions to this problem were larger in scope than PR comments could address. He then took responsibility to drive clarity with the rest of the team and make sure they were all prepared to come up with a new plan.

        Observation created about 5 years ago

      Featuring:Joseph A.Engineering CommunicationTechnical InvestigationCollaborationBack-end engineer

      Joesph was given a big problem. Search on the learn page is slow. The big problem is determining what lessons a user has access to. The majority of the problem has to do with lessons in paths. This was not a part of the application that he had a lot of deep knowledge in. He took a lot of time to create test data (paths in paths in paths with lessons all over the place) and has worked to really understand how all of the parts work together. In fact, I would say know that he really groks it in a way that I do not. I offered him an initial design on how we should solve the problem. After working through all the details, he saw an even better solution that take the last couple steps in the journey to search nirvana. In the midst of all of this, he has done an incredible job communicating the changes with the benefits that they will bring.

        Observation created over 5 years ago

      Featuring:Brittany H.We put learners firstWe share before we're readyWe ask clarifying questionsWe get agreementsBack-end engineer

      Brittany has been taking the lead on our Forced Logout acceleration (doing some discovery, determining the best approach from an architecture standpoint, story shaping, delivery, etc.). While planning and working through some discovery, she ran into some roadblocks. She gave context, asked a clear question, and provided potential solutions so folks could easily comment in hopes to gain clarity and move forward in a timely manner (see the below Slack conversations for examples). Keep up all the great work, Brittany 🎉

      https://lessonly.slack.com/archives/C97TXG1PW/p1592937599264700

      https://lessonly.slack.com/archives/C97TXG1PW/p1592937611265000

        Observation created almost 6 years ago

      Featuring:Thomas C.We put learners firstBack-end engineer

      My main objective this quarter has been to fix bugs that leave learners unable to complete Paths (since learners completing stuff is kind of the reason we exist as a company). Of the 5 big bugs on our radar, we were only able to fix 2 before my newborn son arrived a week and a half early back in December. I fully expected the Learn squad to stay focused on their other important objectives in my absence, but Tom had other ideas. While I was out, he identified and fixed the root cause of another issue (ch36348), and had made major inroads researching the others. On my first day back yesterday when I mentioned Paths in the Learn standup, Tom smiled and said "I've got news for you on that". When we sat down together and Tom explained how he'd gotten to the bottom of several major issues and even fixed one of them (and keep in mind these are bugs that have existed for years which no one has been able to figure out), my outlook on the quarter's goal went from "Well, at least we made a dent..." to "Holy heck, we can do this!" So a big shout-out to Tom for not just working on Paths bugs while I was out, but really working on them, and making progress where no one, myself included, had been able to, to the benefit of the 100,000+ learners affected by them. 👏

        Observation created almost 6 years ago

      Featuring:Ethan M.Joseph A.Joshua A.Waseem D.We ask clarifying questionsWe get agreementsWe inspire others to do better workCommunityDesign CollaborationBack-end engineerFront-end engineerDiscovery engineerEpic shaperStory shaper

      I am grateful for how these 4 have been communicating on this project. This is a complex project for a variety of reasons. We are splitting up the frontend and the backend. Linking elements in our app is a difficult endeavor. The way these four have communicated to one another and to me has been such a joy. Whether it be Waseem posting killer updates in the channel, Joshua and Joseph presenting their findings on technical deep dives, or Ethan walking me through expectations on epic breakdown, everyone has chipped in to really get this off the ground.

      I have been inspired to bring the level of clarity I have found here in other aspects of my job.

      Front-end engineer

      We ship high quality code, we’re highly confident in providing the best experience for our users, and we deliver frontend stories to contribute to the team’s success and keep progress moving forward.

      Full Description

      • We ship high quality code
        • Minimal (less than average) number of regrettable recycles on stories owned. For example:
        • ~90% test coverage
          • So we can (Shared) increase confidence that our code will work as expected
          • Not-you, engineering experience
        • Performance concerns
        • Security concerns
        • Style guide concerns
        • Architectural pattern concerns
        • Hygienic (common conventions) concerns
      • We’re highly confident in providing the best experience for our users
        • Minimal (less than average) number of regrettable remediations on stories owned. For example:
        • Performance issues
        • Authorization issues
        • Functionality issues
        • Error handling issues
      • Delivers frontend stories to contribute to the team’s success and keep progress moving forward
        • Better than average cycle time of active states (as defined in OurGruuv)

      Requirements

      • Must have a position with the reach of 1.1 or higher
      • For this role, you must be milestone 1 or greater inWeb Technologies
      • For this role, you must be milestone 1 or greater inEstimation
      • For this role, you must be milestone 1 or greater inPrioritization
      • For this role, you must be milestone 1 or greater inInitiative
      • For this role, you must be milestone 1 or greater inReact
      • For this role, you must be milestone 1 or greater inCollaboration
      • For this role, you must be milestone 1 or greater inEngineering Communication
      • For this role, you must be milestone 1 or greater inSoftware Investigation

      Examples

        Observation created over 4 years ago

      Featuring:Ethan M.Carolyn W.We put the team before ourselvesFront-end engineer

      Double shout out to our residential front end wizards (or wizard and witch, if you prefer) and "honorary" Practice members, Carolyn and Ethan, for super-ly putting the team first!

      When Ellie was here, they both jumped in to help her sort through front end issues and learn the ropes of our codebase, and now that John and I don't have our own React-Gandalf to look to, they have both made time (lots of it) to answer questions and help us navigate through some weird bugs on a difficult project.

      Carolyn and Ethan, we really appreciate how you've generously given us your time and have been so positive and helpful!

        Observation created about 5 years ago

      Featuring:Donnie W.CollaborationReactFront-end engineer

      Donnie is also very patient with me. He has been a great (frontend) partner on a shared project. He’s always been able to help me improve something I’ve written and or walk me through some of his tips on reviewing. I really appreciate the atmosphere you bring any time we collaborate as well. Thanks

        Observation created about 5 years ago

      Featuring:Ethan M.CollaborationCommunicationCommunityMentorshipReactFront-end engineer

      This is long overdue. Ethan is always very patient with me and no matter how trivial of a question I have, he always gives me his full attention and time. I have been trying to enhance my frontend skills and he is always very willing to help out and I really appreciate it.

        Observation created almost 6 years ago

      Featuring:Ethan M.Joseph A.Joshua A.Waseem D.We ask clarifying questionsWe get agreementsWe inspire others to do better workCommunityDesign CollaborationBack-end engineerFront-end engineerDiscovery engineerEpic shaperStory shaper

      I am grateful for how these 4 have been communicating on this project. This is a complex project for a variety of reasons. We are splitting up the frontend and the backend. Linking elements in our app is a difficult endeavor. The way these four have communicated to one another and to me has been such a joy. Whether it be Waseem posting killer updates in the channel, Joshua and Joseph presenting their findings on technical deep dives, or Ethan walking me through expectations on epic breakdown, everyone has chipped in to really get this off the ground.

      I have been inspired to bring the level of clarity I have found here in other aspects of my job.

        Observation created almost 6 years ago

      Featuring:Conlin D.We put learners firstWe share before we're readyWe ask clarifying questionsWe highlight what's workingWe own our requestsWe recognize the opportunity in challengesWe inspire others to do better workWe don't wait to be told what to do, we take initiativeWe put the team before ourselvesWe challenge ourselvesWe critique, we don't complainCommunityInitiativeMentorshipProduct DiscoveryDiscovery engineerFront-end architectFront-end engineer

      Last week, I did a code review for Conlin. In the PR description, he did a phenomenal job at leaving detailed testing steps and notes around why the story was necessary. Beyond that, however, he also went out of his way to thoroughly talk through the issue on a deeper level. He explained the research he did on the problem, potential solutions (and why they wouldn't work), his decided solution (and why it does work), as well as the history and potential future of the problem. As both a reviewer and fellow engineer, I was really impressed by how much thought and effort went into this.
      While I already find myself aiming to be as clear and informative as possible in my PR descriptions, seeing this inspired me to raise my standard going forward, and left me feeling grateful to work with Conlin.

      PR of Reference - https://github.com/lessonly/lessonly/pull/7482